Attention is currently required from: daniel, laforge, pespin.

View Change

3 comments:

• File include/osmocom/mgcp/mgcp_protocol.h:

  • Patch Set #3, Line 13: #define MGCP_PARSE_SDP_MAXPTIME_UNSET (-1)

    It's not duplicate, it's two different fields.

    ah, i thought it was an enum =)

  • Patch Set #3, Line 14: #define MGCP_PARSE_SDP_RTP_PORT_UNSET (0)

    It's not a closed set of values, but a specific value in an int range, it's fine as a define.

    ack

• File src/libosmo-mgcp/mgcp_protocol.c:

  • Patch Set #3, Line 1139: if (rc < 0) { /* See also RFC 3661: Protocol error */

    I'm actually fine with it the current way, but changing in to avoid discussions.

    yay! =)

To view, visit change 39248. To unsubscribe, or for help writing mail filters, visit settings.