Attention is currently required from: laforge, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 )
Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ......................................................................
Patch Set 6:
(3 comments)
Patchset:
PS6: I still think the entire patches is being done in the wrong perspective. I'd really go for trying to update osmo-bts/osmo-bsc/osmo-pcu to have only 1 message to handle that (deprecating the other one but keeping it for backward compatibility), and I see no intent for that in here.
File src/bts.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/076c65d8_342236d4 PS5, Line 1105: #ifdef ENABLE_ERICSSON_RBS
I have eliminated the need for compile time IF here now but I still wondering, we have different phy […]
Because those are only used for embedded systems.
File src/pcu_l1_if.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/c97bca6c_9f21ec70 PS6, Line 757: bts->use_dt_confirm = (info_ind->flags & PCU_IF_FLAG_DT); Use "!!(...)" to convert it to a 0/1.
-
pespin