Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37685?usp=email ) Change subject: pySim-shell: Support other ADMx values beyond ADM1 from 'verify_adm' ...................................................................... Patch Set 1: (2 comments) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/37685/comment/add00bf8_157a997c PS1, Line 832: '--adm-type', Oh, good to know. Maybe clarify this in the help message? Wasn't obvious to me. Something like `(default is chosen automatically depending on card type; usually 1)`. https://gerrit.osmocom.org/c/pysim/+/37685/comment/2be6de27_f7ae02b2 PS1, Line 842: inverse Oh, I see it's actually a `bidict`. I was not careful enough and assumed that it's a list and that you're getting a value by index. Nevermind. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37685?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icce6903c1e449889f8bc5003ccfe6af767a26d44 Gerrit-Change-Number: 37685 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 02 Aug 2024 09:54:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment