Attention is currently required from: laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37685?usp=email )
Change subject: pySim-shell: Support other ADMx values beyond ADM1 from 'verify_adm' ......................................................................
Patch Set 1:
(2 comments)
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/37685/comment/add00bf8_157a997c PS1, Line 832: '--adm-type',
No, that would break the default ADM number being retrieved from the CardProfile. […]
Oh, good to know. Maybe clarify this in the help message? Wasn't obvious to me. Something like `(default is chosen automatically depending on card type; usually 1)`.
https://gerrit.osmocom.org/c/pysim/+/37685/comment/2be6de27_f7ae02b2 PS1, Line 842: inverse
https://bidict.readthedocs.io/en/main/basic-usage.html uses the inverse[] approach. […]
Oh, I see it's actually a `bidict`. I was not careful enough and assumed that it's a list and that you're getting a value by index. Nevermind.