Attention is currently required from: lynxis lazus.
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40436?usp=email )
Change subject: gsn: fix coding style issue ......................................................................
Patch Set 2:
(9 comments)
File include/osmocom/gtp/gsn.h:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/2d318433_6fb4b990?usp... : PS2, Line 141: int (*cb_data_ind)(struct pdp_t * pdp, "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/0bf05477_3c4e3542?usp... : PS2, Line 150: int (*cb)(struct sockaddr_in * peer)); "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/ca055a36_7fa20f3c?usp... : PS2, Line 153: int (*cb)(struct sockaddr_in * peer)); "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/32214389_a44d2031?usp... : PS2, Line 156: int (*cb)(struct sockaddr_in * peer, union gtpie_member **ie)); "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/ceca4897_6ffff70f?usp... : PS2, Line 159: int (*cb)(int type, int cause, struct pdp_t * pdp, "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/3558e4b9_5e0ab9bb?usp... : PS2, Line 163: int (*cb)(struct sockaddr_in * peer, "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/3f2f1024_d139b66e?usp... : PS2, Line 167: int (*cb)(struct sockaddr_in * peer, "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/fad34a4b_dbf38e6a?usp... : PS2, Line 172: int (*cb)(struct gsn_t * gsn, struct sockaddr_in * peer, "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/26f8b3da_07b8280d?usp... : PS2, Line 172: int (*cb)(struct gsn_t * gsn, struct sockaddr_in * peer, "foo * bar" should be "foo *bar"