Attention is currently required from: laforge, pespin.
pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39558?usp=email )
Change subject: tests: add trau2rtp_gen program
......................................................................
Patch Set 2:
(1 comment)
File tests/trau_conv/trau2rtp_gen.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/39558/comment/8951e53a_ee05e5f0?... :
PS1, Line 212: usage: fprintf(stderr, "usage: %s [-8] [-d] [-x] input-file [output-file]\n",
we usually put goto tags on its own line.
Your forgot this one
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/39558?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I3cc8502406e930317b680b0ace2fce479e495ccd
Gerrit-Change-Number: 39558
Gerrit-PatchSet: 2
Gerrit-Owner: falconia
falcon@freecalypso.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Mon, 17 Feb 2025 23:00:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
pespin@sysmocom.de