Attention is currently required from: daniel, neels, osmith.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36590?usp=email )

Change subject: ttcn3-hnbgw: Apply latest changes to 'with-pfcp' scenario ......................................................................

Patch Set 1:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/docker-playground/+/36590/comment/ff16ef31_956a... PS1, Line 12: Fixes: 6de89a5fb529928ce9b7b3320e0ca2e3e568d458

A commit hash should be "Related:", and "Fixes:" is for redmine issues, right??

I think I already shared with you previously that this is common pattern in projects like linux kernel, which is useful to track with scripts follow-up patches which fix bugs in patches one want to cherry-pick. So I see no problem with it and I actually invite others to do the same.

File ttcn3-hnbgw-test/with-pfcp/HNBGW_Tests.cfg:

https://gerrit.osmocom.org/c/docker-playground/+/36590/comment/390a3f2a_cfdf... PS1, Line 120: + Thanks, I'll fix it.

IMHO we should have one fixed config in osmo-hnbgw.cfg, or only ttcn3 code that adjusts config via VTY.

Yeah probably, but out of the scope for this patch, this needs quite a lot of work, I'm just fixing the running tests because it showed up during weekly meeting this week.

In this case the "duplication" is simply that it needs to match what osmo-hnbgw was cofnigured with, not really "sync" between TTCN3 config files.

this "+" seems to be a copy paste bug -- let me guess, you haven't actually tested this patch..

Yeah I didn't test it, sorry for that, I just wrote the patch while running other ttcn3 testsuites validating the osmo_io fixes I submitted. I'll give them a run today.

File ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg:

https://gerrit.osmocom.org/c/docker-playground/+/36590/comment/95d9d823_ff9a... PS1, Line 26: +

"+" artifact

Ack