Attention is currently required from: daniel, neels, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36590?usp=email ) Change subject: ttcn3-hnbgw: Apply latest changes to 'with-pfcp' scenario ...................................................................... Patch Set 1: (3 comments) Commit Message: https://gerrit.osmocom.org/c/docker-playground/+/36590/comment/ff16ef31_956… PS1, Line 12: Fixes: 6de89a5fb529928ce9b7b3320e0ca2e3e568d458 I think I already shared with you previously that this is common pattern in projects like linux kernel, which is useful to track with scripts follow-up patches which fix bugs in patches one want to cherry-pick. So I see no problem with it and I actually invite others to do the same. File ttcn3-hnbgw-test/with-pfcp/HNBGW_Tests.cfg: https://gerrit.osmocom.org/c/docker-playground/+/36590/comment/390a3f2a_cfd… PS1, Line 120: + Thanks, I'll fix it. Yeah probably, but out of the scope for this patch, this needs quite a lot of work, I'm just fixing the running tests because it showed up during weekly meeting this week. In this case the "duplication" is simply that it needs to match what osmo-hnbgw was cofnigured with, not really "sync" between TTCN3 config files. Yeah I didn't test it, sorry for that, I just wrote the patch while running other ttcn3 testsuites validating the osmo_io fixes I submitted. I'll give them a run today. File ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg: https://gerrit.osmocom.org/c/docker-playground/+/36590/comment/95d9d823_ff9… PS1, Line 26: + Ack -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36590?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie02a0754a6ca985e60e08f1f171f532b6cc16264 Gerrit-Change-Number: 36590 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <daniel(a)totalueberwachung.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: daniel <daniel(a)totalueberwachung.de> Gerrit-Comment-Date: Thu, 18 Apr 2024 09:03:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment