Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31071 )
Change subject: netdev: Fix compilation building with --disable-libmnl ......................................................................
Patch Set 1:
(2 comments)
File src/core/netdev.c:
https://gerrit.osmocom.org/c/libosmocore/+/31071/comment/eebc3667_46954c13 PS1, Line 845: You could actually have the ifdef here and log/return -ENOTSUP. Then there's no message about bringing an interface up/down that we know is wrong.
https://gerrit.osmocom.org/c/libosmocore/+/31071/comment/9a4c71d3_db4982bd PS1, Line 855: LOGNETDEV(netdev, LOGL_NOTICE, "%s: NOT SUPPORTED. Build libosmocore with --enable-libmnl.\n", __func__); I'm torn whether these should actually abort the program. This should at least be LOGL_ERROR, though.
Same on the other hunks