fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27566 )

Change subject: library/BSSMAP_Templates: add missing LCS Client Type IE ......................................................................

library/BSSMAP_Templates: add missing LCS Client Type IE

According to 3GPP TS 48.008, section 3.2.1.71, the LCS Client Type IE shall be present if the location type indicates a request for a location estimate and is optional otherwise. Since [1], osmo-bsc started to check presence of this IE, so let's make sure that it's present in ts_BSSMAP_Perform_Location_Request by default.

Change-Id: I5c8d6962e957d587dc4b65d08bf56bd4ef2f0d6e Related: [1] osmo-bsc.git Id3262e67c3dc25cb93fbd52a40689c5529ca2d41 Related: SYS#5891 --- M library/BSSMAP_Templates.ttcn 1 file changed, 14 insertions(+), 4 deletions(-)

Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve neels: Looks good to me, but someone else must approve fixeria: Looks good to me, approved

diff --git a/library/BSSMAP_Templates.ttcn b/library/BSSMAP_Templates.ttcn index 57422cc..07c7c8d 100644 --- a/library/BSSMAP_Templates.ttcn +++ b/library/BSSMAP_Templates.ttcn @@ -1872,9 +1872,19 @@ positioningMethod := omit }

-template (value) PDU_BSSAP ts_BSSMAP_Perform_Location_Request(template (omit) BSSMAP_IE_IMSI imsi, - template (omit) BSSMAP_IE_CellIdentifier cellIdentifier := omit - ) +template (value) BSSMAP_IE_LCSClientType +ts_BSSMAP_IE_LCSClientType(template (value) BIT4 category := '0010'B, + template (value) BIT4 subtype := '0000'B) := { + elementIdentifier := '48'O, + lengthIndicator := 0, /* overwritten */ + subtype := subtype, + category := category +} + +template (value) PDU_BSSAP +ts_BSSMAP_Perform_Location_Request(template (omit) BSSMAP_IE_IMSI imsi, + template (omit) BSSMAP_IE_CellIdentifier cellIdentifier := omit, + template (omit) BSSMAP_IE_LCSClientType clientType := ts_BSSMAP_IE_LCSClientType) modifies ts_BSSAP_BSSMAP := { pdu := { bssmap := { @@ -1883,7 +1893,7 @@ locationType := ts_BSSMAP_IE_LocationType, cellIdentifier := cellIdentifier, classmarkInformationType3 := omit, - lCS_ClientType := omit, + lCS_ClientType := clientType, chosenChannel := omit, lCS_Priority := omit, lCS_QOS := omit,