Attention is currently required from: neels, pespin.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431 )

Change subject: context map: introduce RUA and SCCP FSMs to fix leaks ......................................................................

Patch Set 5: Code-Review+1

(2 comments)

File include/osmocom/hnbgw/context_map.h:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/ce2ee4d9_2f263045 PS5, Line 22: enum map_rua_fsm_event { not critical, but this is where the ISO/OSI style request/indication naming could be useful to clearly see the direction of such an "event". the _RX_ are indications telling the FSM that something happens. Just like SCCP_DISC, HNB_LINK_LOST. Where TX_RANAP_MSG and _EV_PLEASE_DISCONNECT are requests to the FSM.

File src/osmo-hnbgw/hnbgw_rua.c:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/3a993d43_7a99de14 PS5, Line 183: { RUA_ProcedureCode_id_Connect, "id-Connect" },

AFAIK the messages are called "id-Connect" in RUA, including the "id-", whatever the meaning may be

No, the procdures are not called "id-Connect", but "CONNECT". See the section headlines of 25.468 9.1.x.

That "id-" some artefact of the asn.1 syntax, so they have differnt names for the identifier from the type name.