Attention is currently required from: neels, pespin.

Patch set 5:Code-Review +1

View Change

2 comments:

• File include/osmocom/hnbgw/context_map.h:

  • Patch Set #5, Line 22: enum map_rua_fsm_event {

    not critical, but this is where the ISO/OSI style request/indication naming could be useful to clearly see the direction of such an "event". the _RX_ are indications telling the FSM that something happens. Just like SCCP_DISC, HNB_LINK_LOST. Where TX_RANAP_MSG and _EV_PLEASE_DISCONNECT are requests to the FSM.

• File src/osmo-hnbgw/hnbgw_rua.c:

  • Patch Set #5, Line 183: { RUA_ProcedureCode_id_Connect, "id-Connect" },

    AFAIK the messages are called "id-Connect" in RUA, including the "id-", whatever the meaning may be

    No, the procdures are not called "id-Connect", but "CONNECT". See the section headlines of 25.468 9.1.x.

    That "id-" some artefact of the asn.1 syntax, so they have differnt names for the identifier from the type name.

To view, visit change 31431. To unsubscribe, or for help writing mail filters, visit settings.