Attention is currently required from: fixeria. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 ) Change subject: rlcmac: Refactor msg_type enums and value_string ...................................................................... Patch Set 3: (3 comments) File src/rlcmac/ts_44_060.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3201): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/b2f95953_f25d5380 PS3, Line 80: { OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_DOWNLINK_ACK_NACK , "Pkt DL ACK/NACK" }, space prohibited before that ',' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3201): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/6a560397_62844f5a PS3, Line 88: { OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_ENHANCED_MEASUREMENT_REPORT, "Pkt Enchanced Meas Report" }, 'Enchanced' may be misspelled - perhaps 'Enhanced'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3201): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/94d41a1b_61ddb597 PS3, Line 92: { OSMO_GPRS_RLCMAC_UL_MSGT_ENHANCED_MEASUREMENT_REPORT, "Enchanced Meas Report" }, 'Enchanced' may be misspelled - perhaps 'Enhanced'? -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic55782d90c0d7876fc37d1da130b859857c11447 Gerrit-Change-Number: 31152 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 17:25:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment