laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/41999?usp=email )

Change subject: dahdi_base.c: Avoid unnecessary strlen call when with strncat. ......................................................................

dahdi_base.c: Avoid unnecessary strlen call when with strncat.

It is not necessary to call strlen on the destination buffer when calling strncat.

Resolves: #89 Change-Id: Idd3e6145682e276abb9bc67029df974197bf8b1b --- M drivers/dahdi/dahdi-base.c 1 file changed, 2 insertions(+), 4 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/99/41999/1

diff --git a/drivers/dahdi/dahdi-base.c b/drivers/dahdi/dahdi-base.c index 0aa1de7..6411e52 100644 --- a/drivers/dahdi/dahdi-base.c +++ b/drivers/dahdi/dahdi-base.c @@ -5449,14 +5449,12 @@ */ continue; } - strncat(vi.echo_canceller + strlen(vi.echo_canceller), - ec_name, space); + strncat(vi.echo_canceller, ec_name, space); space -= strlen(ec_name); if (space < 1) break; if (cur->list.next && (cur->list.next != &ecfactory_list)) { - strncat(vi.echo_canceller + strlen(vi.echo_canceller), - ", ", space); + strncat(vi.echo_canceller, ", ", space); space -= 2; if (space < 1) break;