Attention is currently required from: pespin.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34215 )

Change subject: Introduce osmo-dia2gsup-master, ttcn3-dia2gsup-test ......................................................................

Patch Set 2:

(5 comments)

File osmo_dia2gsup-master/Dockerfile:

https://gerrit.osmocom.org/c/docker-playground/+/34215/comment/da478e61_f7d8... PS2, Line 19: rebar3 escriptize Maybe copy the resulting `osmo-dia2gsup` to `/usr/local/bin` here, so that it's easier to call it?

https://gerrit.osmocom.org/c/docker-playground/+/34215/comment/56786f55_6184... PS2, Line 26: --config /data/osmo_dia2gsup.config You're passing the config file twice. Isn't the `ERL_FLAGS` enough?

File ttcn3-dia2gsup-test/Makefile:

https://gerrit.osmocom.org/c/docker-playground/+/34215/comment/afabce0e_653f... PS2, Line 1: ws

File ttcn3-dia2gsup-test/jenkins.sh:

https://gerrit.osmocom.org/c/docker-playground/+/34215/comment/d225df93_13fe... PS2, Line 6: debian-bookworm-erlang This looks like a dependency of `osmo_dia2gsup-$IMAGE_SUFFIX`, and should not be listed here if so. This script is not using this image directly.

https://gerrit.osmocom.org/c/docker-playground/+/34215/comment/ee96b35a_1d8f... PS2, Line 31: /bin/sh -c "ERL_FLAGS='-config /data/osmo_dia2gsup.config' /tmp/osmo_dia2gsup/_build/default/bin/osmo-dia2gsup --config /data/osmo_dia2gsup.config >/data/osmo_dia2gsup.log 2>&1" This line is already specified in `CMD` of the respective Dockerfile, why duplicating it here?