Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42033?usp=email )
Change subject: osmo-bts-trx: apply 'max-initial' value before POWERON ......................................................................
Patch Set 2:
(2 comments)
File src/osmo-bts-trx/trx_provision_fsm.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42033/comment/0daae303_26cda3b4?usp=... : PS2, Line 229: l1h->config.setpower_sent = true;
Missing: "l1h->config.nomtxpower_acked = false;" […]
Acknowledged
https://gerrit.osmocom.org/c/osmo-bts/+/42033/comment/b35fffec_e2d7bfce?usp=... : PS2, Line 294: (l1h->config.setformat_acked) &&
This () can actually be dropped, instead of adding new ones 😊
I prefer to have those braces, so that this new line is aligned with the existing ones.
-
fixeria