laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/33152 ) Change subject: serial: return a return code in reset_card() ...................................................................... serial: return a return code in reset_card() The method reset_card does not return a return code, while the coresponding pcsc implementation does return 1 on success. Change-Id: I658dd6857580652696b4a77e7d6cfe5778f09eff --- M pySim/transport/serial.py 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/transport/serial.py b/pySim/transport/serial.py index 924df9e..3313a5e 100644 --- a/pySim/transport/serial.py +++ b/pySim/transport/serial.py @@ -104,6 +104,7 @@ raise NoCardError() elif rv < 0: raise ProtocolError() + return rv def _reset_card(self): self._atr = None -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I658dd6857580652696b4a77e7d6cfe5778f09eff Gerrit-Change-Number: 33152 Gerrit-PatchSet: 2 Gerrit-Owner: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: tobias &lt;t-osmocom.org(a)tobias.org&gt; Gerrit-MessageType: merged