Attention is currently required from: Hoernchen.

lynxis lazus has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email )

Change subject: ccid: fix rdr_to_pc_parameters and rdr_to_pc_hardware_error ......................................................................

Patch Set 1:

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157/comment/dead1962_d08... : PS1, Line 8:

Just to be clear, both messages were just plain wrong, there is no "different" wrong or "different" […]

What is wrong? "The messages in the spec were different." should be also part of the commit messages.

A commit message should explain why you did the change and gives the reader more information than "just read the code" and you know what's wrong.

`fix "stuff"` can mean anything from filling the wrong data, from not sending the data at all

This is such an important change (the part of rdr_to_pc_parameters) in difference to the rdr_to_pc_hardware_error, which is currently not in use.