Attention is currently required from: msuraev.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30013 )
Change subject: virt_phy: support building with -Werror
......................................................................
Patch Set 1:
(1 comment)
File src/host/virt_phy/src/l1ctl_sap.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30013/comment/5ba55650_e1e32931
PS1, Line 583: #if 0
Please add comment clarifying why it's commented
with preprocessor instead of simply being removed.
I cannot simply remove this code
because I am not the one who wrote it. I guess it was added for the sake of completeness,
as a counterpart of the l1ctl_cs_by_osmo[] and get_l1ctl_cs_by_osmo().
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30013
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Iccd2575faadee1ad3982466bf6a07fa5d52b0250
Gerrit-Change-Number: 30013
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 06 Nov 2022 20:54:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment