neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/35876?usp=email )

Change subject: cosmetic: tweak sdp_audio_codecs_by_payload_type() ......................................................................

cosmetic: tweak sdp_audio_codecs_by_payload_type()

No functional change, only more readable code.

Change-Id: I3c4e29cb240e2a9a00bc9dd065ec85a5e8d8fe38 --- M src/libmsc/sdp_msg.c 1 file changed, 14 insertions(+), 5 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/76/35876/1

diff --git a/src/libmsc/sdp_msg.c b/src/libmsc/sdp_msg.c index cd721d3..9d787ad 100644 --- a/src/libmsc/sdp_msg.c +++ b/src/libmsc/sdp_msg.c @@ -179,20 +179,18 @@ if (codec->payload_type == payload_type) return codec; } - if (!create) return NULL;

- /* Not found; codec points after the last entry now. */ - if ((codec - ac->codec) >= ARRAY_SIZE(ac->codec)) + if (ac->count >= ARRAY_SIZE(ac->codec)) return NULL;

+ codec = &ac->codec[ac->count]; *codec = (struct sdp_audio_codec){ .payload_type = payload_type, .rate = 8000, }; - - ac->count = (codec - ac->codec) + 1; + ac->count++; return codec; }