Attention is currently required from: pespin, fixeria, dexter.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29924 )
Change subject: Move UL allocation&assign functions to gprs_ms.c
......................................................................
Patch Set 3:
(2 comments)
File src/gprs_ms.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/29924/comment/3b6b34a2_f0ae84c9
PS3, Line 1091:
unrelated
File src/tbf_fsm.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/29924/comment/197acaf5_a0189d8a
PS3, Line 105: ul_tbf_contention_resolution_start(ul_tbf);
looks like a slight change in functionality - maybe explain in the commit message why this is needed or split it out into a different patch?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/29924
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I256aeede2a2678c9738539fb6ec4db9766fa85e4
Gerrit-Change-Number: 29924
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Thu, 03 Nov 2022 08:49:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment