Attention is currently required from: falconia, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/34448?usp=email )
Change subject: SMS over GSUP: implement vty config of SMSC routing ......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/hlr/hlr_sms.h:
https://gerrit.osmocom.org/c/osmo-hlr/+/34448/comment/c3f853fa_dd6d58db PS2, Line 17: void smsc_del(struct hlr_smsc *smsc);
I modeled this code after the existing one for EUSEs and USSD routes, which - as @fixeria noted - us […]
My opinion is that in 88% of the code we use alloc+free, so in general those named _del should be moved to _free (as long as they can be considered free function as per what they do).
Semantics of free functions for object pointers are clear. They get a nullable heap allocated pointer and free it together with all fields/subobjects.