Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29361 )

Change subject: pcu_sock: check size of primitive ......................................................................

Patch Set 1:

(5 comments)

File include/osmocom/bsc/pcu_if.h:

Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-883): https://gerrit.osmocom.org/c/osmo-bsc/+/29361/comment/11eb5f28_92e8e9a4 PS1, Line 8: #define PCUIF_HDR_SIZE ( sizeof(struct gsm_pcu_if) - sizeof(((struct gsm_pcu_if *)0)->u) ) space prohibited after that open parenthesis '('

Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-883): https://gerrit.osmocom.org/c/osmo-bsc/+/29361/comment/1dff3189_4e103130 PS1, Line 8: #define PCUIF_HDR_SIZE ( sizeof(struct gsm_pcu_if) - sizeof(((struct gsm_pcu_if *)0)->u) ) space prohibited before that close parenthesis ')'

File src/osmo-bsc/pcu_sock.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-883): https://gerrit.osmocom.org/c/osmo-bsc/+/29361/comment/a806d8ba_85a8f7a1 PS1, Line 451: #define CHECK_IF_MSG_SIZE(prim_len, prim_msg) \ Macros with flow control statements should be avoided

Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-883): https://gerrit.osmocom.org/c/osmo-bsc/+/29361/comment/5493025c_54894d7a PS1, Line 451: #define CHECK_IF_MSG_SIZE(prim_len, prim_msg) \ do {} while (0) macros should not be semicolon terminated

Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-883): https://gerrit.osmocom.org/c/osmo-bsc/+/29361/comment/dc52e197_dad7c4b8 PS1, Line 459: } while(0); space required before the open parenthesis '('