Attention is currently required from: laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31062 )
Change subject: Introduce netdev API
......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/core/netdev.h:
https://gerrit.osmocom.org/c/libosmocore/+/31062/comment/4a7f01e8_bdd3957a
PS2, Line 31: unsigned
AFAICT, in the kernel, an ifindex is always of type
"int", not "unsigned int".
see "man
if_nametoindex()":
unsigned int if_nametoindex(const char *ifname);
On success, if_nametoindex() returns the index number of the network interface; on error,
0 is returned and errno is set to indicate the error.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31062
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7a00c0445a89e088676a4897061b65196d9197f1
Gerrit-Change-Number: 31062
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 24 Jan 2023 17:59:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment