[S] Change in pysim[master]: saip-tool: add commandline option to edit mandatory services list - gerrit-log

27 Mar 2025


      Attention is currently required from: dexter.
fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39863?usp=email )
Change subject: saip-tool: add commandline option to edit mandatory services list
......................................................................
Patch Set 1:
(1 comment)
File pySim/esim/saip/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/39863/comment/dfefc56b_167d88a4?usp=ema... :
PS1, Line 1356: if service_name in self.decoded['eUICC-Mandatory-services'].keys():
Maybe it's worth letting the user know that they're trying to remove something that is not present in the service list, rather than doing nothing and not even printing a warning?
-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/39863?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I120b98d4b0942c26674bc1365c5711101ec95235
Gerrit-Change-Number: 39863
Gerrit-PatchSet: 1
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Thu, 27 Mar 2025 20:52:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No