Change in osmocom-bb[master]: modem: Initial integration of libosmo-gprs-rlcmac - gerrit-log

26 Jan 2023


      Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31077 )
Change subject: modem: Initial integration of libosmo-gprs-rlcmac
......................................................................
Patch Set 4:
(1 comment)
File src/host/layer23/src/modem/llc.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/31077/comment/0162fc54_674868e4 
PS4, Line 145: osmo_static_assert
...
I believe this assertion should be done in libosmo-gprs. […]
It cannot be done in the lib code because they don't depend on one another. It could be done in a unit test on top of here, but having the comment in the header of the libs is enough for now imho.
-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31077
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I0e628d9ddaa5ad6a205f07746d4176d1b8df7eb0
Gerrit-Change-Number: 31077
Gerrit-PatchSet: 4
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Thu, 26 Jan 2023 15:42:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Gerrit-MessageType: comment