Attention is currently required from: fixeria, pespin.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed: Code-Review-1 by fixeria, Verified+1 by Jenkins Builder
Change subject: {bs,ms}_power_control: Move params inside lchan_power_ctrl_state ......................................................................
{bs,ms}_power_control: Move params inside lchan_power_ctrl_state
Those fields are also part of the power control state, since they are modified through the lifecycle of the lchan eg. during rx of CHAN (RE)ACT, MS POWER CONTROL, etc. Those should also be reset together with other fields.
Moreover, with this patch we get rid of an extra indirection pointer which could be NULL (under static configuration) and hence create potential problems.
Change-Id: I0e2a6c2c33e0ac9a0bc1734d83eaeafc27f2f4df --- M include/osmo-bts/lchan.h M src/common/power_control.c M src/common/rsl.c M src/common/vty.c M tests/power/bs_power_loop_test.c M tests/power/ms_power_loop_test.c 6 files changed, 74 insertions(+), 88 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/07/41807/4