fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31911 )
Change subject: on_dso_load_select: run after on_dso_load_ctx
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/31911/comment/3c87dfe9_a177a211
PS3, Line 10: Otherwise osmo_ctx->global (used via define OTC_GLOBAL) points to NULL
It would be more correct to say: "Otherwise `osmo_ctx` is NULL, so by using `OTC_GLOBAL` defined as `osmo_ctx->global` we're dereferencing NULL". But LGTM, not critical at all.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31911
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia2518e82530b93c535f8f5105513e21559b895ba
Gerrit-Change-Number: 31911
Gerrit-PatchSet: 4
Gerrit-Owner: osmith
osmith@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Tue, 14 Mar 2023 15:28:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment