Attention is currently required from: dexter.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34575?usp=email )

Change subject: gprs_rlcmac_sched: check if we really use direct phy ......................................................................

Patch Set 2: Code-Review-1

(1 comment)

File src/gprs_rlcmac_sched.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/34575/comment/331bfa00_0802ff26 PS2, Line 491: if (bts->trx[trx].fl1h) { I think this is breaking/changing the behavior when osmo-bts-sysmo is used without direct-phy flag. IIUC when you compile osmo-pcu-sysmo, ENABLE_DIRECT_PHY is set and hence blocks were always transmitted no matter if the direct-pcu was used or not, which makes sense, since you always want to ends up transmitting blocks to lower layer, that happening in osmo-bts or osmo-pcu.