Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32240 )
Change subject: Move GPRS NSE under BTS SiteMgr ......................................................................
Patch Set 1:
(2 comments)
File include/osmo-bts/bts_sm.h:
https://gerrit.osmocom.org/c/osmo-bts/+/32240/comment/7d832391_069306d3 PS1, Line 43: gprs
`pcu_state` is also related to GPRS, but not part of this struct. […]
I liked having the .gprs suffix in the previous place, so I'm keeping here. We can move pcu_state to .gprs later on in another commit.
File src/common/bts_sm.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32240/comment/bbd58577_7b9eb955 PS1, Line 77: %d", 0
just have `0` in the format string and use `osmo_fsm_inst_update_id()`?
Ack
-
pespin