Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39563?usp=email ) Change subject: Add Gn support to allow MME->SGSN, SGSN->MME cell reselection ...................................................................... Patch Set 4: (13 comments) File src/sgsn/gprs_gmm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/8a423123_a0fb244a?us… : PS4, Line 2568: if (mmctx) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/f2e11639_7e44b71f?us… : PS4, Line 2597: if (!mme) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/ee85e7eb_eb4e3ed9?us… : PS4, Line 2627: } else { else is not generally useful after a break or return File src/sgsn/gprs_rau_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/66aec894_7e7f2a9b?us… : PS4, Line 365: .in_event_mask = S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_GGSN_UPD_RESP) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) File src/sgsn/sgsn_libgtp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/5b588349_f8ea26c7?us… : PS4, Line 190: if (!ggsn->gsn) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/7e9c9b97_97ee3dd2?us… : PS4, Line 913: #define CHECK_SPACE_ERR(bytes) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/67fc3ce3_26cc1717?us… : PS4, Line 918: #define MEMCPY_CHK(dst, src, len) \ Macros with multiple statements should be enclosed in a do - while loop Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/d2e9afd9_af176260?us… : PS4, Line 918: #define MEMCPY_CHK(dst, src, len) \ macros should not use a trailing semicolon Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/cf35a5d5_a3fcbaca?us… : PS4, Line 1085: LOGMMCTXP(LOGL_INFO, mmctx, "Ctx will be transfered to another SGSN/MME\n"); 'transfered' may be misspelled - perhaps 'transferred'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/3d921016_23917243?us… : PS4, Line 1125: if (buf_len <= 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/37c7e3eb_a6c42072?us… : PS4, Line 1139: // break; please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/cd9b64a0_4c7e8849?us… : PS4, Line 1378: strncpy(mmctx->imsi, imsi_str, sizeof(mmctx->imsi)); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/ea37619d_a98eb9f5?us… : PS4, Line 1388: if (rc) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39563?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iffe83b31db2b6e6869fedf2351375184096cff6f Gerrit-Change-Number: 39563 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus &lt;lynxis(a)fe80.eu&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus &lt;lynxis(a)fe80.eu&gt; Gerrit-Comment-Date: Mon, 17 Feb 2025 10:37:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No