Attention is currently required from: dexter, laforge, osmith.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37456?usp=email )
Change subject: pySim-smpp2sim.py: Simulate SMSC+CN+RAN+UE for OTA testing ......................................................................
Patch Set 4:
(2 comments)
File pySim-smpp2sim.py:
https://gerrit.osmocom.org/c/pysim/+/37456/comment/d980a673_aa3de1de PS3, Line 41: from zope.interface import implementer
I believe it's an upstraeam dependency of twisted. https://docs.twisted.org/en/twisted-17.5. […]
Not sure if it's a good idea to import packages from indirect dependencies, as we have no control over it. In theory, it can happen that `twisted` removes this dependency, so we end up in a broken state.
Not blocking, just raising a concern.
https://gerrit.osmocom.org/c/pysim/+/37456/comment/54931dde_55364070 PS3, Line 95: submit
unused?
Done
-
fixeria