Attention is currently required from: dexter, laforge, osmith.

View Change

2 comments:

• File pySim-smpp2sim.py:

  • Patch Set #3, Line 41: from zope.interface import implementer

    I believe it's an upstraeam dependency of twisted. https://docs.twisted.org/en/twisted-17.5. […]

    Not sure if it's a good idea to import packages from indirect dependencies, as we have no control over it. In theory, it can happen that `twisted` removes this dependency, so we end up in a broken state.

    Not blocking, just raising a concern.

  • Patch Set #3, Line 95: submit

    unused?

    Done

To view, visit change 37456. To unsubscribe, or for help writing mail filters, visit settings.