Attention is currently required from: arehbein, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33652 )
Change subject: ipa: Add segmentation callback ......................................................................
Patch Set 3:
(2 comments)
File src/ipa.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33652/comment/6d747a33_dfb61b7a PS2, Line 378: MSG_CB_IPA_PROTO_EXT_IS_SET_OFFSET
It's the offset for the variable that tells us if the extended IPA protocol information is set in th […]
Can we simply have a packed struct instead of those? (answer is probably: yes! good idea!)
https://gerrit.osmocom.org/c/libosmo-netif/+/33652/comment/43ca8096_f777c2cf PS2, Line 432: /* Below: Helper functions for addition of send_ipa functionality in later commit */
it's weird to introduce static inline helper functions in a commit thta doesn't use those.
Specially in a .c file :) Looks like it should be removed.
-
pespin