Attention is currently required from: arehbein, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33652 ) Change subject: ipa: Add segmentation callback ...................................................................... Patch Set 3: (2 comments) File src/ipa.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33652/comment/6d747a33_dfb61b7a PS2, Line 378: MSG_CB_IPA_PROTO_EXT_IS_SET_OFFSET Can we simply have a packed struct instead of those? (answer is probably: yes! good idea!) https://gerrit.osmocom.org/c/libosmo-netif/+/33652/comment/43ca8096_f777c2cf PS2, Line 432: /* Below: Helper functions for addition of send_ipa functionality in later commit */ Specially in a .c file :) Looks like it should be removed. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33652 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I87ef4c7023126b783dd79e7ed47be31e1b76f975 Gerrit-Change-Number: 33652 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 10 Jul 2023 08:40:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment