Attention is currently required from: arehbein, laforge.

View Change

2 comments:

• File src/ipa.c:

  • Patch Set #2, Line 378: MSG_CB_IPA_PROTO_EXT_IS_SET_OFFSET

    It's the offset for the variable that tells us if the extended IPA protocol information is set in th […]

    Can we simply have a packed struct instead of those? (answer is probably: yes! good idea!)

  • Patch Set #2, Line 432: /* Below: Helper functions for addition of send_ipa functionality in later commit */

    it's weird to introduce static inline helper functions in a commit thta doesn't use those.

    Specially in a .c file :) Looks like it should be removed.

To view, visit change 33652. To unsubscribe, or for help writing mail filters, visit settings.