Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37617?usp=email )
Change subject: sgsn: Introduce test TC_attach_pdp_act_pmm_idle
......................................................................
Patch Set 2:
(3 comments)
File sgsn/BSSGP_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37617/comment/0c56b293_fac5…
PS2, Line 663: var RANAP_PDU ranap;
unused
Ack
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37617/comment/bc84fd05_493a…
PS2, Line 671: timer T := 5.0;
you are not starting this timer?
Ack
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37617/comment/1907e317_1e9c…
PS2, Line 784: var template Recovery_gtpc recovery := omit;
It's always `omit` in this altstep, so just pass
`omit` to `ts_GTPC_UpdatePdpRespGGSN`?
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37617?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id46ccd9db11c8b792e1c071de91ef092ed1544c7
Gerrit-Change-Number: 37617
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 29 Jul 2024 08:28:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment