Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27724 )

Change subject: osmo-bts-virtual: remove unused 'codec_mode_request' argument ......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1:

I would expect once the #if0 blocks are properly implemented we need to know the AMR phase (CMC/CMR) […]

This block is related to the hack, that was introduced in the early days to detect and compensate lost Uplink speech blocks in the Downlink burst handler. This makes no sense in the context of osmo-bts-virtual, so I suggest to remove it completely.

Note that this block is also present in the osmo-bts-trx specific copy of tx_tch_common(), and there it's uncommented: https://gitea.osmocom.org/cellular-infrastructure/osmo-bts/src/branch/master.... I proposed to remove it back in 2020: https://gerrit.osmocom.org/c/osmo-bts/+/20674, because with a) per-lchan burst loss detection and b) NOPE.ind it makes no sense to keep it anymore.