Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/34471?usp=email )
Change subject: abis_nm: delay configure_loop() until NM_MT_SW_ACTIVATED_REP
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bsc/+/34471/comment/64f53dd0_4ac15ef3
PS1, Line 42: plus for the ip.access
: specific MOs
Oh, I actually forgot to update those MOs: GPRS Cell, GPRS NSE, and GPRS NSVC.
https://gerrit.osmocom.org/c/osmo-bsc/+/34471/comment/c51450ba_f90f3c1b
PS1, Line 51: expected to fix
Expected but does not (as can be seen from a recent PCAP provided by @pespin).
File src/osmo-bsc/nm_bb_transc_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/34471/comment/53d1b22c_927987f9
PS1, Line 116: /* nanoBTS only: delay until SW Activated Report is received */
agreed, this would make it easier to understand
Ack, I'll update this patch soon.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/34471?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3953a5e41eb27165f9ff203cac7447ee9d311abf
Gerrit-Change-Number: 34471
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 22 Sep 2023 14:44:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment