Attention is currently required from: dexter, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36973?usp=email ) Change subject: add pySim.esim.es9p with definitions of the ES9+ HTTP Interface ...................................................................... Patch Set 4: (3 comments) File pySim/esim/es9p.py: https://gerrit.osmocom.org/c/pysim/+/36973/comment/2fece790_75ffecb0 PS4, Line 21: import json : from da not used in this module https://gerrit.osmocom.org/c/pysim/+/36973/comment/c3eab6ac_e2245199 PS4, Line 32: param cosmetic: class names should follow CamelCase naming https://gerrit.osmocom.org/c/pysim/+/36973/comment/7e9eafdb_a6c4c680 PS4, Line 153: FIXME HACK what's wrong here? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I194ef1d186391f36245c099cc70a4813185ecf9c Gerrit-Change-Number: 36973 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jun 2024 08:08:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment