[S] Change in osmo-e1d[master]: proto_clnt: close osmo-e1d control socket on connection loss - gerrit-log

21 Apr 2023


      Attention is currently required from: dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/32388 )
Change subject: proto_clnt: close osmo-e1d control socket on connection loss
......................................................................
Patch Set 1:
(1 comment)
File src/proto_clnt.c:
https://gerrit.osmocom.org/c/osmo-e1d/+/32388/comment/18580c43_8a2c2987 
PS1, Line 92: LOGP(DE1D, LOGL_ERROR, "Lost connection with osmo-e1d control socket.\n");
            : 		close(ofd->fd);
            : 		ofd->fd = 0;
are we sure the only reason for a NULL return is that the connection was lost?
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/32388
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I3e1a29a9701a9432f58ef7cfedc32c916203017a
Gerrit-Change-Number: 32388
Gerrit-PatchSet: 1
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly andreas@eversberg.eu
Gerrit-Reviewer: tnt tnt@246tNt.com
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Thu, 20 Apr 2023 22:31:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment