Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32428 ) Change subject: layer23: modem: Unregister registered callbacks upon app exit ...................................................................... Patch Set 3: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/32428/comment/b15b00eb_7b1300d4 PS3, Line 7: layer23: modem: Unregister registered callbacks upon app exit what's missing in the commit message is why doing this is necessary File src/host/layer23/src/modem/app_modem.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32428/comment/3252b1be_45120f42 PS3, Line 117: static int global_signal_cb(unsigned int subsys, unsigned int signal, please fix alignment -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32428 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5a641fa3dadb6ea7346b25a20215896ab32eb805 Gerrit-Change-Number: 32428 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 20:50:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment