Attention is currently required from: laforge.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/33421
)
Change subject: cosmetic: Implement cmd2.Settable backwards-compat via wrapper class
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Patchset:
PS2:
Nice idea!
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/33421/comment/19ec3472_31494643
PS2, Line 196: pylint: disable=too-many-function-args
I guess all these attributes and `\` symbols are no more needed?
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/33421
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Id234f3fa56fe7eff8e1153d71b9be8a2e88dd112
Gerrit-Change-Number: 33421
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Sun, 25 Jun 2023 18:41:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment