Attention is currently required from: lynxis lazus, neels. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email ) Change subject: vlr: add PS support ...................................................................... Patch Set 11: (2 comments) File src/libvlr/vlr_lu_fsm.c: https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/0cee781c_7069fb7d?usp… : PS11, Line 1583: we have to resend the complete message 5x times Are you sure that "we" is really the VLR (not the PCU) who should be re-sending the messages up to 5 times? Do you have a spec. reference here? I am asking because the PCU will normally repeat sending PDUs several times until the MS ACKnowledges reception or the TBF times out. https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/3bc3d094_c4794079?usp… : PS11, Line 1604: case VLR_ULA_S_WAIT_IMSI: Why not handling `VLR_ULA_S_WAIT_AUTH` here? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0 Gerrit-Change-Number: 38490 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 24 Aug 2025 19:56:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No