Attention is currently required from: fixeria, laforge, lynxis lazus, osmith.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093?usp=email )
Change subject: epdg: Add tests to validate concurrent connections ......................................................................
Patch Set 2:
(3 comments)
File epdg/EPDG_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093/comment/ce89f84e_fda62... PS1, Line 747:
maybe put the several deleted lines in an extra patch?
Ack, this would make the patch a bit easier to read.
File epdg/EPDG_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093/comment/3c4b4f56_f10d9... PS2, Line 797: -> sender vc_conn `vc_conn` is not used after assignment, so `-> sender vc_conn` can be dropped? Maybe we want `from vc_conn_list[i]` instead?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093/comment/fc17a3ba_6ac2c... PS2, Line 805: -> sender vc_conn Likewise here.