Attention is currently required from: daniel, lynxis lazus.

pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37867?usp=email )

Change subject: Refactor diffing same GMM messages ......................................................................

Patch Set 14: Code-Review+1

(2 comments)

File src/sgsn/gprs_gmm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/37867/comment/7d7653ab_0647a475?usp... : PS5, Line 1445: return -1;

is this an error? shouldn't it be 1? (see description above).

Done

File src/sgsn/gprs_gmm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/37867/comment/99e7d650_71e5921c?usp... : PS14, Line 1434: * return 1 if length unequal So it's not clear what happened when it returns 1. We may want to change this case to "2".