Change in osmo-ttcn3-hacks[master]: library/GSM_Types: fix encoding of BcdMccMnc (3 octets) - gerrit-log

8 Feb 2023


      Attention is currently required from: fixeria, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31241 )
Change subject: library/GSM_Types: fix encoding of BcdMccMnc (3 octets)
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1: 
I somehow remember having  thought that the TITAN codec was supposed to take care of BCD nibble swapping with the right encoder setting.  In that case our encoder function would have generated the non-swapped nibbles, and the titan encoder taken care of the swapping.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31241
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifa3083fdd6307b56baa1ef3ac85a3e7a2efab728
Gerrit-Change-Number: 31241
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Wed, 08 Feb 2023 06:24:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment