Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, osmith.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email )

Change subject: Use talloc to allocate asn1c decoded structs ......................................................................

Patch Set 2:

(1 comment)

File src/tcap.c:

https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219/comment/acd97320_ddb5... : PS2, Line 29: vo

Breaking applications forgetting to do so is the point 😊 I actually would consider it very positive […]

well it's not applications forgetting to do so, it's applications which could compile fine against the library and suddenly they cannot anymore because they require to declare a global pointer. So that's basically a non-compatible API break...

In practice, it's not osmo-stp, but any program which links against libosmo-sigtran, ie. osmo-bsc, osmo-sgsn, osmo-msc, osmo-smlc, etc.

By providing a function API to set the pointer, like I did, all those apps can be left untouched since they won't be using the TCAP features anyway, and only add the call to the API to osmo-stp, which btw is in the same repo as libosmo-sigtran.