Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33706 )
Change subject: trxcon/l1sched: fix handling of UL FACCH on TCH/A[FH]S ......................................................................
Patch Set 1:
(2 comments)
File src/host/trxcon/src/sched_lchan_tchf.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/33706/comment/11be3503_f66741f5 PS1, Line 255: data_len -= 2;
why not using sizeof(struct amr_hdr) as the comment indicates?
Because it's defined in `libosmo-netif`, and I don't really want to add a new lib dependency just to know size of a header...
File src/host/trxcon/src/sched_lchan_tchh.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/33706/comment/28c20e44_a474727b PS1, Line 468: data_len -= 2;
same
Same.