Attention is currently required from: laforge, pespin, dexter.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310 )
Change subject: mgwpool: Document keepalive feature
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File common/chapters/mgwpool.adoc:
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310/comment/469bbed7_3d2b…
PS1, Line 190: Pool
what's the problem with pool?
elsewhere in
the document it is MGW pool with lowercase p. Not that important.
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310/comment/b8e6dc5e_c764…
PS1, Line 211: NOTE: The `keepalive` feature is disabled by default, and must be
explicitly configured in order to enable it.
Because older osmo-mgw versions don't support the
"null" endpoint, and they should be configured exp […]
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I2cb4e2098b71b386278eb6026271a6d786a34c2a
Gerrit-Change-Number: 33310
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Jun 2023 12:38:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment