Attention is currently required from: fixeria, osmith.

pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41126?usp=email )

Change subject: s1gw: test S1GW originated PFCP Heartbeat ......................................................................

Patch Set 2:

(1 comment)

File s1gw/S1GW_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41126/comment/f90646d9_c2826... : PS2, Line 1016: if (mp_rest_enable) { I'm not following why do you wanto mix here the PFPC HEartbet procedures on both directions. IMHO they are totally separate thing and should be triggered in different places.

Actually, I don't really understand why would one want to trigger an initiating PFCP procedure over the REST interface instead of having a configurable timer inside osmo-s1gw...