Attention is currently required from: pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31049 )

Change subject: llc: Initial support for GRR-UNITDATA.ind/req ......................................................................

Patch Set 2:

(2 comments)

File src/llc/llc.c:

https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/70f06c50_4c593af1 PS2, Line 315: gprs_llc_prim_alloc_grr_unitdata_req(lle->llme->tlli, NULL, 4096 - sizeof(llc_prim)) Shorter and still readable I'd say:

``` llc_prim = (g_ctx->location == OSMO_GPRS_LLC_LOCATION_SGSN)? gprs_llc_prim_alloc_bssgp_dl_unitdata_req(lle->llme->tlli, NULL, 4096 - sizeof(llc_prim) : gprs_llc_prim_alloc_grr_unitdata_req(lle->llme->tlli, NULL, 4096 - sizeof(llc_prim)); ```

https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/551be388_f8904856 PS2, Line 758: llc_prim_tx->ll.unitdata_ind.apply_gea = !drop_cipherable; /* TODO: is this correct? */ Can you tell me how we handle TODOs/FIXMEs in our codebase/when we upload them into our codebase? I've also seen a couple of such commits in our existing code so I assume this is done on purpose.