Attention is currently required from: pespin.

View Change

2 comments:

• File src/llc/llc.c:

  • Patch Set #2, Line 315: gprs_llc_prim_alloc_grr_unitdata_req(lle->llme->tlli, NULL, 4096 - sizeof(llc_prim))

    Shorter and still readable I'd say:

    ```
    llc_prim = (g_ctx->location == OSMO_GPRS_LLC_LOCATION_SGSN)?
               gprs_llc_prim_alloc_bssgp_dl_unitdata_req(lle->llme->tlli, NULL, 4096 - sizeof(llc_prim) :
               gprs_llc_prim_alloc_grr_unitdata_req(lle->llme->tlli, NULL, 4096 - sizeof(llc_prim));
    ```

  • Patch Set #2, Line 758: llc_prim_tx->ll.unitdata_ind.apply_gea = !drop_cipherable; /* TODO: is this correct? */

    Can you tell me how we handle TODOs/FIXMEs in our codebase/when we upload them into our codebase? I've also seen a couple of such commits in our existing code so I assume this is done on purpose.

To view, visit change 31049. To unsubscribe, or for help writing mail filters, visit settings.